Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic vm transfer transaction #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dynamic vm transfer transaction #138

wants to merge 1 commit into from

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Dec 17, 2024 •
edited
Loading

Description

  • Fixes transaction failure case when moving Flow from EVM to Cadence with primary balance coming from EVM by leaving enough FLOW in Cadence to cover storage consumption.

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Dec 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (02aab3f) to head (b8f3e08).
Report is 183 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   86.19%   86.73%   +0.53%     
==========================================
  Files          18       18              
  Lines         884      965      +81     
==========================================
+ Hits          762      837      +75     
- Misses        122      128       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review December 17, 2024 02:03
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner December 17, 2024 02:03
@sisyphusSmiling sisyphusSmiling requested a review from a team December 17, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdtf nvdtf Awaiting requested review from nvdtf

At least 1 approving review is required to merge this pull request.

Assignees

@sisyphusSmiling sisyphusSmiling

Labels
Bugfix
Projects
FlowEVM Bridge
Status: In Review
🌊 Flow 4D
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisyphusSmiling @codecov-commenter